fix: make media_buy_ids optional in get_media_buy_delivery #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the AdCP specification, all parameters for get_media_buy_delivery are optional. When media_buy_ids is omitted, the operation should return delivery data for all media buys the requester has access to, filtered by the provided criteria (status_filter, start_date, end_date, buyer_refs). Changes: - Remove incorrect validation requiring media_buy_ids in A2A server handler - Pass all optional parameters (buyer_refs, status_filter, start_date, end_date) to core implementation - Update docstring to clarify that omitting media_buy_ids queries all accessible buys - Add test case verifying optional media_buy_ids behavior The core implementation (_get_media_buy_delivery_impl) already handled this correctly, filtering by status when no IDs were provided. The bug was only in the A2A server's parameter validation layer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Nov 5, 2025
Resolved conflict in templates/add_product_gam.html by keeping our tree API approach for hierarchical size extraction (required for child ad unit sizes) while incorporating debug logging from main. Conflict resolution: - Kept tree API fetch (not flat list) for edit mode initialization - Preserved recursive cacheTreeUnits() function for hierarchical caching - Added debug console.log statements from main for troubleshooting - This ensures child ad unit sizes are available for format matching Other changes from main: - Remove MCP protocol test button and APIs (PR #702) - Make media_buy_ids optional per AdCP spec (PR #704) - Fix User record creation during OAuth (PR #701) - Fix inventory fetching for placements (multiple commits) - Various bug fixes and improvements Tests: Will run after merge completion 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…pec (adcontextprotocol#704) Per the AdCP specification, all parameters for get_media_buy_delivery are optional. When media_buy_ids is omitted, the operation should return delivery data for all media buys the requester has access to, filtered by the provided criteria (status_filter, start_date, end_date, buyer_refs). Changes: - Remove incorrect validation requiring media_buy_ids in A2A server handler - Pass all optional parameters (buyer_refs, status_filter, start_date, end_date) to core implementation - Update docstring to clarify that omitting media_buy_ids queries all accessible buys - Add test case verifying optional media_buy_ids behavior The core implementation (_get_media_buy_delivery_impl) already handled this correctly, filtering by status when no IDs were provided. The bug was only in the A2A server's parameter validation layer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per the AdCP specification, all parameters for
get_media_buy_deliveryshould be optional. Whenmedia_buy_idsis omitted, the operation should return delivery data for all media buys the requester has access to, filtered by the provided criteria.Changes
media_buy_idsin A2A server handlerbuyer_refs,status_filter,start_date,end_date) to core implementationmedia_buy_idsbehaviorTesting
All unit tests pass. New test verifies that requests without
media_buy_idsare accepted and parameters are correctly forwarded to the core implementation.