Skip to content

Conversation

@bokelley
Copy link
Contributor

@bokelley bokelley commented Nov 5, 2025

Remove the MCP protocol test interface from the admin UI.

This removes the /mcp-test route, its template, API endpoint, and all related tests. The test functionality is no longer needed as development can be done through external MCP clients. All tests pass and the admin UI starts successfully without this feature.

🤖 Generated with Claude Code

Removed the MCP test interface from the admin UI as it's no longer needed:

- Removed `/mcp-test` route from core.py
- Removed `/api/mcp-test/call` API endpoint from api.py
- Deleted mcp_test.html template file
- Removed MCP test button from index.html navigation
- Removed MCP test link from signup_complete.html
- Deleted placeholder mcp_test.py blueprint file
- Removed mcp_test_bp registration from app.py
- Deleted test_mcp_protocol.py integration test file
- Updated test_blueprint_imports.py to remove mcp_test references
- Updated test_admin_ui_routes_comprehensive.py to remove mcp_test route test
- Updated test_template_url_validation.py to remove mcp_test from critical routes

All tests pass and the admin UI starts successfully without the MCP test functionality.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@bokelley bokelley force-pushed the remove-mcp-test-button branch from 1d5bbb4 to 34c9539 Compare November 5, 2025 02:08
@bokelley bokelley merged commit 5c96324 into main Nov 5, 2025
10 checks passed
bokelley added a commit that referenced this pull request Nov 5, 2025
Resolved conflict in templates/add_product_gam.html by keeping our tree API approach for hierarchical size extraction (required for child ad unit sizes) while incorporating debug logging from main.

Conflict resolution:
- Kept tree API fetch (not flat list) for edit mode initialization
- Preserved recursive cacheTreeUnits() function for hierarchical caching
- Added debug console.log statements from main for troubleshooting
- This ensures child ad unit sizes are available for format matching

Other changes from main:
- Remove MCP protocol test button and APIs (PR #702)
- Make media_buy_ids optional per AdCP spec (PR #704)
- Fix User record creation during OAuth (PR #701)
- Fix inventory fetching for placements (multiple commits)
- Various bug fixes and improvements

Tests: Will run after merge completion

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton pushed a commit to Newton-Research-Inc/salesagent that referenced this pull request Nov 24, 2025
…extprotocol#702)

Removed the MCP test interface from the admin UI as it's no longer needed:

- Removed `/mcp-test` route from core.py
- Removed `/api/mcp-test/call` API endpoint from api.py
- Deleted mcp_test.html template file
- Removed MCP test button from index.html navigation
- Removed MCP test link from signup_complete.html
- Deleted placeholder mcp_test.py blueprint file
- Removed mcp_test_bp registration from app.py
- Deleted test_mcp_protocol.py integration test file
- Updated test_blueprint_imports.py to remove mcp_test references
- Updated test_admin_ui_routes_comprehensive.py to remove mcp_test route test
- Updated test_template_url_validation.py to remove mcp_test from critical routes

All tests pass and the admin UI starts successfully without the MCP test functionality.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants