Fix webhook delivery: restart simulations on server startup #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Delivery simulator uses daemon threads that don't survive server restarts - When Fly.io restarts the app, all active simulations are lost - Media buys created before restart never send webhooks Solution: - Added restart_active_simulations() method to DeliverySimulator - Queries database for active media buys with webhook configs - Restarts simulations for mock adapter products on server startup - Called from initialize_application() during startup - Updated AdCP schemas to latest from registry This ensures webhooks resume after server restarts, fixing the issue where fast-callback-test products stop sending webhooks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Oct 24, 2025
Problem: - delivery_simulator.py was checking product.adapter_type on line 98 - Products don't have adapter_type - adapters are configured at tenant level - This caused AttributeError on server startup, breaking deployment - Bug introduced in PR #347 (commit 6c4ef08) Solution: - Query tenant instead of checking non-existent product.adapter_type - Check tenant.adapter_type (the correct field) - Add Tenant to imports This fixes the production deployment hang. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Oct 24, 2025
Problem: - delivery_simulator.py was checking product.adapter_type on line 98 - Products don't have adapter_type - adapters are configured at tenant level - This caused AttributeError on server startup, breaking deployment - Bug introduced in PR #347 (commit 6c4ef08) Solution: - Query tenant instead of checking non-existent product.adapter_type - Check tenant.adapter_type (the correct field) - Add Tenant to imports This fixes the production deployment hang. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…tprotocol#347) Problem: - Delivery simulator uses daemon threads that don't survive server restarts - When Fly.io restarts the app, all active simulations are lost - Media buys created before restart never send webhooks Solution: - Added restart_active_simulations() method to DeliverySimulator - Queries database for active media buys with webhook configs - Restarts simulations for mock adapter products on server startup - Called from initialize_application() during startup - Updated AdCP schemas to latest from registry This ensures webhooks resume after server restarts, fixing the issue where fast-callback-test products stop sending webhooks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…contextprotocol#595) Problem: - delivery_simulator.py was checking product.adapter_type on line 98 - Products don't have adapter_type - adapters are configured at tenant level - This caused AttributeError on server startup, breaking deployment - Bug introduced in PR adcontextprotocol#347 (commit 6c4ef08) Solution: - Query tenant instead of checking non-existent product.adapter_type - Check tenant.adapter_type (the correct field) - Add Tenant to imports This fixes the production deployment hang. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
restart_active_simulations()method to DeliverySimulatorinitialize_application()during server startupTesting
Impact