Skip to content

Fix product add 500 error and JSON serialization #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
Oct 16, 2025
Merged

Fix product add 500 error and JSON serialization #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/admin/blueprints/products.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,11 @@ def get_creative_formats(
)

format_dict = {
"id": fmt.format_id, # Use "id" to match database schema (AdCP spec)
"id": (
fmt.format_id.id
if isinstance(fmt.format_id, object) and hasattr(fmt.format_id, "id")
else str(fmt.format_id)
), # Extract string ID from FormatId object
"agent_url": fmt.agent_url,
"name": fmt.name,
"type": fmt.type,
Expand Down Expand Up @@ -552,13 +556,8 @@ def add_product(tenant_id):
f"Use 'Browse Ad Units' to select valid ad units.",
"error",
)
return render_template(
"add_product_gam.html",
tenant_id=tenant_id,
tenant_name=tenant.name,
form_data=form_data,
error="Invalid ad unit IDs",
)
# Redirect to form instead of re-rendering to avoid missing context
return redirect(url_for("products.add_product", tenant_id=tenant_id))

base_config["targeted_ad_unit_ids"] = id_list

Expand Down Expand Up @@ -787,6 +786,7 @@ def add_product(tenant_id):
return render_template(
"add_product_gam.html",
tenant_id=tenant_id,
tenant_name=tenant.name,
inventory_synced=inventory_synced,
formats=get_creative_formats(tenant_id=tenant_id),
authorized_properties=properties_list,
Expand Down