Skip to content

Fix product formats not saving on add/edit (#486) #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
Oct 16, 2025
Merged

Fix product formats not saving on add/edit (#486) #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/core/json_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,16 +239,18 @@ def validate_formats(self, key, value):
for fmt in value:
try:
if isinstance(fmt, dict):
# Legacy: Extract format_id from Format object for backward compatibility
format_id = fmt.get("format_id", "unknown")
if not format_id or format_id == "unknown":
# AdCP spec uses "id" field, but we store full format objects
# Accept both "id" (AdCP spec) and "format_id" (legacy)
format_id = fmt.get("id") or fmt.get("format_id")
if not format_id:
# Skip invalid format objects instead of failing
import logging

logger = logging.getLogger(__name__)
logger.warning(f"Skipping format object without valid format_id: {fmt}")
logger.warning(f"Skipping format object without id or format_id: {fmt}")
continue
validated_formats.append(format_id)
# Store the full format object (with agent_url and id)
validated_formats.append(fmt)
elif isinstance(fmt, str):
# Current approach: Store format IDs as strings
if not fmt.strip():
Expand Down