fix: Remove non-existent fields from SyncCreativesResponse #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyncCreativesResponse only contains domain data (creatives, dry_run). Protocol fields (status, task_id, etc.) are added by the A2A protocol layer. Fixes AttributeError: 'SyncCreativesResponse' object has no attribute 'status'
- Clarifies that asset_id (not asset_role) must be used as the key in creative manifests - Adds documentation that asset_role is for human-readable documentation only - Syncs with official AdCP spec at adcontextprotocol.org
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…ync-creatives-response-fields fix: Remove non-existent fields from SyncCreativesResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
'SyncCreativesResponse' object has no attribute 'status'error when syncing creatives to the Wonderstruck sales agent via A2A protocol.Problem
The
_handle_sync_creatives_skillmethod in the A2A server was attempting to access fields (status,summary,results,assignments_summary,assignment_results,context_id,task_id) that don't exist on theSyncCreativesResponsePydantic model.Per the AdCP v2.4 spec (PR #113),
SyncCreativesResponseonly contains domain data:creatives(list ofSyncCreativeResult)dry_run(optional boolean)Protocol fields like
statusandtask_idshould be added by the A2A protocol layer, not extracted from the domain response.Changes
Modified
_handle_sync_creatives_skillto only return fields that actually exist onSyncCreativesResponse:success: True(static, since we reach this code only on successful execution)creatives(from response.creatives)dry_run(from response.dry_run)message(string representation using__str__method)Testing
Tested with creative sync from Conductor agentic API to Wonderstruck sales agent - error no longer occurs.
🤖 Generated with Claude Code