Add explicit logging for tenant detection header values #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will show exactly what Host, Apx-Incoming-Host, and x-adcp-tenant headers we're receiving, which will help us understand why tenant detection is failing for MCP calls.
Root cause: FastMCP's get_http_headers() wasn't returning all headers, but the raw Starlette request.headers has everything. Solution: Extract headers from context.request_context.request.headers and create MinimalContext (same pattern A2A uses). This ensures MCP and A2A handle tenant detection identically. Why A2A worked: A2A already extracted headers directly from raw request. Why MCP failed: MCP relied on get_http_headers() which was incomplete. This fix makes MCP match A2A's working pattern.
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…tocol#589) * Add logger.info() for tenant detection headers visibility This will show exactly what Host, Apx-Incoming-Host, and x-adcp-tenant headers we're receiving, which will help us understand why tenant detection is failing for MCP calls. * Fix MCP tenant detection by extracting headers from raw request Root cause: FastMCP's get_http_headers() wasn't returning all headers, but the raw Starlette request.headers has everything. Solution: Extract headers from context.request_context.request.headers and create MinimalContext (same pattern A2A uses). This ensures MCP and A2A handle tenant detection identically. Why A2A worked: A2A already extracted headers directly from raw request. Why MCP failed: MCP relied on get_http_headers() which was incomplete. This fix makes MCP match A2A's working pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows exactly what Host, Apx-Incoming-Host, and x-adcp-tenant headers are received. This will help diagnose why tenant detection fails for MCP.