Use logger.error for visible MCP debugging #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - print() to stderr doesn't appear in Fly logs - console.print() doesn't appear in Fly logs - Cannot diagnose why MCP tenant detection is failing Solution: - Add logger.error() calls with 🔍 emoji at key points in get_principal_from_context() - Shows: - Whether context is passed and what type - What attributes context has (meta, headers, etc.) - What get_http_headers() returns - Which fallback path is taken - Final outcome This will finally give us visibility into what's happening. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
Problem: - print() to stderr doesn't appear in Fly logs - console.print() doesn't appear in Fly logs - Cannot diagnose why MCP tenant detection is failing Solution: - Add logger.error() calls with 🔍 emoji at key points in get_principal_from_context() - Shows: - Whether context is passed and what type - What attributes context has (meta, headers, etc.) - What get_http_headers() returns - Which fallback path is taken - Final outcome This will finally give us visibility into what's happening. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Multiple PRs added debugging with print and console.print but none of it appears in Fly logs. Cannot diagnose why Test Agent MCP is failing.
Solution: Replace invisible debugging with logger.error calls that show up in production logs.
Added debugging with magnifying glass emoji at key points in get_principal_from_context showing context type, get_http_headers results, fallback paths, and final outcome.
Testing: All tests pass. Fixed test compatibility with Mock objects. logger.error output will be visible in Fly logs.