Skip to content

Fix migration: Update ALL adapter_config rows, not just mock #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmmaLouise2018 merged 1 commit into from
Oct 24, 2025
Merged

Fix migration: Update ALL adapter_config rows, not just mock #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions alembic/versions/e38f2f6f395a_add_mock_manual_approval_required.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ def upgrade() -> None:
# Add mock_manual_approval_required column to adapter_config table
op.add_column('adapter_config', sa.Column('mock_manual_approval_required', sa.Boolean(), nullable=True))

# Set default value to False for existing rows
op.execute("UPDATE adapter_config SET mock_manual_approval_required = false WHERE adapter_type = 'mock'")
# Set default value to False for ALL existing rows (not just mock adapters)
op.execute("UPDATE adapter_config SET mock_manual_approval_required = false")

# Make the column non-nullable after setting defaults
op.alter_column('adapter_config', 'mock_manual_approval_required', nullable=False, server_default=sa.false())
Expand Down