Skip to content

Fix schema generator trailing newline inconsistency #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
Oct 25, 2025
Merged

Fix schema generator trailing newline inconsistency #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/e2e/adcp_schema_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ async def _download_schema_index(self) -> dict[str, Any]:
# Save to cache
with open(cache_path, "w") as f:
json.dump(index_data, f, indent=2)
f.write("\n") # Add trailing newline for pre-commit compatibility

# Save new metadata
metadata = {
Expand All @@ -183,6 +184,7 @@ async def _download_schema_index(self) -> dict[str, Any]:
}
with open(meta_path, "w") as f:
json.dump(metadata, f, indent=2)
f.write("\n") # Add trailing newline for pre-commit compatibility

return index_data

Expand Down Expand Up @@ -256,6 +258,7 @@ async def _download_schema(self, schema_ref: str) -> dict[str, Any]:
# Save to cache
with open(cache_path, "w") as f:
json.dump(schema_data, f, indent=2)
f.write("\n") # Add trailing newline for pre-commit compatibility

# Save new metadata
metadata = {
Expand All @@ -266,6 +269,7 @@ async def _download_schema(self, schema_ref: str) -> dict[str, Any]:
}
with open(meta_path, "w") as f:
json.dump(metadata, f, indent=2)
f.write("\n") # Add trailing newline for pre-commit compatibility

return schema_data

Expand Down