Skip to content

fix: Remove fake media_buy_id from pending/async responses #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
Oct 28, 2025
Merged

fix: Remove fake media_buy_id from pending/async responses #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/adapters/mock_ad_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,10 +403,14 @@ def create_media_buy(

# Handle question asking (return pending with question)
if scenario.should_ask_question:
# For question-asking scenario, return response without media_buy_id
# The media buy hasn't been created yet - we need input first
# The workflow_step_id will track this pending operation
return CreateMediaBuyResponse(
media_buy_id=f"pending_question_{id(request)}",
media_buy_id=None, # No media buy yet - pending user input
creative_deadline=None,
buyer_ref=request.buyer_ref or "unknown",
packages=[], # No packages yet - operation not complete
errors=[],
)

Expand Down Expand Up @@ -513,11 +517,15 @@ def _create_media_buy_async(
else:
self.log(" Manual completion required - use complete_task tool")

# Return pending response
# For async mode, return response without media_buy_id or packages
# The media buy hasn't been created yet - it's being processed asynchronously
# The workflow_step_id (from step['step_id']) will track this pending operation
# Client can poll the step or wait for webhook notification when complete
return CreateMediaBuyResponse(
buyer_ref=request.buyer_ref or "unknown",
media_buy_id=f"pending_{step['step_id']}",
media_buy_id=None, # No media buy yet - async processing in progress
creative_deadline=None,
packages=[], # No packages yet - operation not complete
errors=[],
)

Expand Down Expand Up @@ -555,7 +563,9 @@ def _create_media_buy_sync_with_delay(

# Continue with immediate processing
self.log("✅ SYNC delay completed, proceeding with creation")
return self._create_media_buy_immediate(request, packages, start_time, end_time, package_pricing_info=package_pricing_info)
return self._create_media_buy_immediate(
request, packages, start_time, end_time, package_pricing_info=package_pricing_info
)

def _create_media_buy_immediate(
self,
Expand Down Expand Up @@ -665,7 +675,7 @@ def _create_media_buy_immediate(
else:
# Fallback to legacy package.cpm
rate = p.cpm
total_budget += (rate * p.impressions / 1000)
total_budget += rate * p.impressions / 1000

# Apply strategy-based bid adjustment
if self.strategy_context and hasattr(self.strategy_context, "get_bid_adjustment"):
Expand Down