Optimize vertical spacing in targeting keys list #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced padding and font sizes to fit more targeting keys on screen: - List item padding: 0.75rem → 0.5rem vertical, 1.25rem → 0.75rem horizontal - Title font: 0.9rem with tighter margin (0.15rem) - Subtitle font: 0.75rem with reduced line height - Badge size: 0.7rem with compact padding - Min height: 50px → 40px This allows viewing more targeting keys without scrolling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
… endpoint The endpoint was passing network_code and refresh_token directly to GAMInventoryDiscovery, but the constructor expects an AdManagerClient and tenant_id. This caused a 500 error when clicking on targeting keys. Fixed by: - Creating OAuth2 client with refresh token credentials - Initializing AdManagerClient with the OAuth client - Passing the client to GAMInventoryDiscovery constructor - Updated integration test to match new constructor signature This matches the pattern used in background_sync_service.py. Fixes: "Failed to load values. Please try again." error 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
force-pushed
the
targeting-keys-compact
branch
from
dc7384d to
ba0fc60
Compare
9 tasks
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
* style: optimize vertical spacing in targeting keys list Reduced padding and font sizes to fit more targeting keys on screen: - List item padding: 0.75rem → 0.5rem vertical, 1.25rem → 0.75rem horizontal - Title font: 0.9rem with tighter margin (0.15rem) - Subtitle font: 0.75rem with reduced line height - Badge size: 0.7rem with compact padding - Min height: 50px → 40px This allows viewing more targeting keys without scrolling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: correct GAMInventoryDiscovery initialization in targeting values endpoint The endpoint was passing network_code and refresh_token directly to GAMInventoryDiscovery, but the constructor expects an AdManagerClient and tenant_id. This caused a 500 error when clicking on targeting keys. Fixed by: - Creating OAuth2 client with refresh token credentials - Initializing AdManagerClient with the OAuth client - Passing the client to GAMInventoryDiscovery constructor - Updated integration test to match new constructor signature This matches the pattern used in background_sync_service.py. Fixes: "Failed to load values. Please try again." error 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
UI Optimization (style)
Bug Fix (fix)
Fixed
GAMInventoryDiscoveryinitialization in targeting values endpoint:network_codeandrefresh_tokendirectlytest_targeting_values_endpoint.pyto verify the new constructor signatureTest plan
🤖 Generated with Claude Code