fix: inventory sync status now checks GAMInventory table instead of Products

[bokelley]

Problem

The dashboard was incorrectly showing "Inventory Sync" as incomplete (❌ red X) for tenants that had synced inventory but hadn't created products yet.

Example: "The Weather Company" tenant showed inventory sync as incomplete, but the Inventory Management page showed 36,750 items synced on Nov 04, 2025.

Root Cause

The setup checklist service was checking the Product table instead of the GAMInventory table to determine if inventory was synced. Since products are created AFTER inventory sync, this created a false negative.

Solution

Changed the inventory sync check in SetupChecklistService._check_critical_tasks() to query the GAMInventory table, which stores the actual synced ad units, placements, and targeting options from the ad server.

Changes

• ✅ Updated src/services/setup_checklist_service.py to query GAMInventory instead of Product
• ✅ Improved status details to show exact inventory count (e.g., "36,750 inventory items synced")
• ✅ Updated test fixtures to include GAMInventory records
• ✅ Added unit tests (tests/unit/test_inventory_sync_status.py)
• ✅ Kept Products check as separate, independent task

Impact

• Tenants with synced inventory will now correctly show inventory sync as complete ✅
• Inventory sync status is now independent of whether products have been created
• The Weather Company (and similar tenants) will see correct status immediately after deployment

Testing

• ✅ Unit tests pass (2 new tests in test_inventory_sync_status.py)
• ✅ Integration test fixtures updated with GAMInventory records
• ✅ All pre-commit hooks pass
• ✅ No data migration required

Before

Critical Tasks:
  ❌ Inventory Sync - (but actually 36,750 items synced)
  ❌ Products - No products created

After

Critical Tasks:
  ✅ Inventory Sync - 36,750 inventory items synced
  ❌ Products - No products created

🤖 Generated with Claude Code