fix: remove top-level budget requirement from create_media_buy #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per AdCP v2.2.0 spec, budget is specified at the PACKAGE level, not at the media buy level. This fixes the A2A server handler that was incorrectly requiring a top-level budget parameter. Changes: - A2A handler: Removed 'budget' from required_params list - A2A handler: Updated to only accept budget via parameters.get() - A2A handler: Updated example to show budget at package level - Docstrings: Clarified that budget is DEPRECATED at top level Fixes issue where clients using npm library were getting validation errors for missing top-level budget field. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…textprotocol#725) Per AdCP v2.2.0 spec, budget is specified at the PACKAGE level, not at the media buy level. This fixes the A2A server handler that was incorrectly requiring a top-level budget parameter. Changes: - A2A handler: Removed 'budget' from required_params list - A2A handler: Updated to only accept budget via parameters.get() - A2A handler: Updated example to show budget at package level - Docstrings: Clarified that budget is DEPRECATED at top level Fixes issue where clients using npm library were getting validation errors for missing top-level budget field. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per AdCP v2.2.0 spec, budget is specified at the PACKAGE level, not the media buy level. This fixes the A2A server handler that was incorrectly requiring a top-level budget parameter, which was causing validation errors for clients using the npm library.
Changes
budgetfrom required_params list in A2A handlerparameters.get()(optional)Root Cause
Commit 5e3250b (Oct 6) incorrectly added budget to required_params when enforcing AdCP spec compliance, but tests weren't catching this because they included budget at both levels.
🤖 Generated with Claude Code