Fix: Default publisher_properties to 'all' when not specified #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #758 - Product creation now succeeds when no properties are set **Problem:** Products without properties/property_ids/property_tags set would fail validation with "Product must have at least one publisher_property" because effective_properties() returned None. **Solution:** Modified Product.effective_properties to default to the "all" variant when no properties are specified: ```python {"publisher_domain": tenant_domain, "selection_type": "all"} ``` This matches the AdCP PublisherProperties schema (first variant) and ensures all products have valid publisher_properties. **Changes:** - src/core/database/models.py: Update effective_properties to return default "all" variant instead of None - Updated docstring to document default behavior **Testing:** - All 48 AdCP contract tests pass - Verified Pydantic validation accepts the new format - Tested Product creation with minimal fields 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
…extprotocol#759) Fixes adcontextprotocol#758 - Product creation now succeeds when no properties are set **Problem:** Products without properties/property_ids/property_tags set would fail validation with "Product must have at least one publisher_property" because effective_properties() returned None. **Solution:** Modified Product.effective_properties to default to the "all" variant when no properties are specified: ```python {"publisher_domain": tenant_domain, "selection_type": "all"} ``` This matches the AdCP PublisherProperties schema (first variant) and ensures all products have valid publisher_properties. **Changes:** - src/core/database/models.py: Update effective_properties to return default "all" variant instead of None - Updated docstring to document default behavior **Testing:** - All 48 AdCP contract tests pass - Verified Pydantic validation accepts the new format - Tested Product creation with minimal fields 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #758 - Products now default to the AdCP "all" variant for publisher_properties when no properties are explicitly set, ensuring all products have valid publisher_properties.
Problem
Products created without properties/property_ids/property_tags would fail validation with "Product must have at least one publisher_property per AdCP spec."
Solution
Modified
Product.effective_propertiesto default to{"publisher_domain": tenant_domain, "selection_type": "all"}instead of returning None, matching the first variant of the AdCP PublisherProperties discriminated union.Testing
All 1001 tests pass (955 unit + 31 integration + 15 integration_v2), including all AdCP contract validation tests.