feat: Add AdCP 2.5 extension to A2A agent card #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AgentExtension to agent card capabilities declaring AdCP version and supported protocols - Extension URI: https://adcontextprotocol.org/schemas/2.5.0/protocols/adcp-extension.json - Declares adcp_version: 2.5.0 and protocols_supported: [media_buy, creative, signals] - Add comprehensive tests for extension in agent card (unit + integration) - Update A2A README with AdCP 2.5 extension documentation Per AdCP 2.5 spec, agent cards should declare their AdCP capabilities via the capabilities.extensions field using the official adcp-extension schema. Tests: - test_agent_card_adcp_extension: validates extension structure and values - test_well_known_agent_json_endpoint_live: validates extension in HTTP response
Addressing review feedback: - Changed protocols_supported from [media_buy, creative, signals] to [media_buy] - Added clear comments explaining protocol version vs library version - Updated tests to expect only media_buy protocol - Updated documentation to reflect current protocol support The agent currently only implements the media_buy protocol domain. Other protocols (creative, signals) are not yet supported.
The adcp library currently provides: - __version__ (2.12.0) - library/package version - get_adcp_version() (v1) - schema version But does not provide the protocol version (2.5.0) needed for the AdCP 2.5 agent card extension. This should be reported upstream as a missing API. Until fixed, we must hardcode ADCP_PROTOCOL_VERSION = '2.5.0'.
Upgrade to adcp 2.12.1 which fixes the upstream issue:
- get_adcp_version() now returns protocol version ("2.5.0")
- Previously returned schema version ("v1")
Changes:
- Upgrade adcp from 2.12.0 to 2.12.1 in pyproject.toml
- Import and use get_adcp_version() for protocol_version
- Remove hardcoded ADCP_PROTOCOL_VERSION constant
- Remove upstream issue TODO (fixed in 2.12.1)
The protocol version is now dynamically obtained from the library
instead of being hardcoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add AdCP 2.5 protocol extension to agent card that declares AdCP version and supported protocol domains. Upgrades adcp library to 2.12.1 which provides the protocol version via
get_adcp_version().Changes
AgentExtensiontocapabilities.extensionsin agent cardTest Plan