Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtitle delay function #355

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

mediaminister
Copy link
Contributor

@mediaminister mediaminister commented Feb 17, 2023

This fixes a bug in the subtitle delay function used by the server-side ad insertion anvato format.
Subtitle timings were possibly wrong after an ad break.
Altough this function is not used for the new Popcorn SDK 6 format, it's good practice to fix wrong logic in the codebase.

@mediaminister mediaminister changed the title Fix subtite delay function Fix subtitle delay function Feb 17, 2023
@michaelarnauts michaelarnauts merged commit ff46259 into add-ons:master Jul 23, 2023
@michaelarnauts michaelarnauts added this to the v1.4.2 milestone Jul 26, 2023
@michaelarnauts michaelarnauts added the bug Something isn't working label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants