Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: ContextMenu.Play Format uri string if there is a duration present. #32

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

MarcelRoozekrans
Copy link
Contributor

No description provided.

@MarcelRoozekrans MarcelRoozekrans changed the title Bugfix: Fixed format string if there is a duration present. Bugfix: ContextMenu.Play Format uri string if there is a duration present. Jun 9, 2020
@michaelarnauts
Copy link
Contributor

You are right. Calling isoformat on the duration was obviously wrong. How did you trigger the bug? Are you trying to integrate another addon? Any other placeholders that could be usefull?

@MarcelRoozekrans
Copy link
Contributor Author

Yeah, nearing completion of a NLZIET addon where I implemented the iptvmanager. The starttime and duration is exactly what I needed to request the right stream.

@michaelarnauts
Copy link
Contributor

Okay, I see.

I was thinking to use the middle of the program (starttime + duration/2), since I've noticed that when the network changes the EPG due to small changes in the schedule, it can start the previous program instead (it does a lookup to find a program that airs at the starttime, and this doesn't work when a program is shifted 5 minutes later. Something that happens with VRT Nu).

@michaelarnauts
Copy link
Contributor

This is only needed for Kodi 18 btw, in Kodi 19, I use the stream parameter from the JSON-EPG.

I'm also thinking of using this information also in Kodi 18 to directly start the right stream, so we don't need to do the lookup. I would need to cache the dict then somehow, or parse the xml to look for the stream.

What are the possibilities with NLZIET?

@michaelarnauts
Copy link
Contributor

I'll merge this one, and we can continue in #29 for this.

@michaelarnauts michaelarnauts merged commit b0b33d5 into add-ons:master Jun 10, 2020
@dagwieers dagwieers added the bug Something isn't working label Jun 11, 2020
@dagwieers dagwieers added this to the v0.1.0 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants