Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use direct URI to play programs from the EPG in Kodi 18 #34

Merged
merged 6 commits into from
Jun 12, 2020

Conversation

michaelarnauts
Copy link
Contributor

@michaelarnauts michaelarnauts commented Jun 11, 2020

This is an attempt to solve issue #29 and also make the experience in Kodi 18 better. It's also a huge hack.

  • Fixes the issue with sys.listitem that isn't the same as xbmc.getInfoLabel(ListItem.xxx) since we only use the sys.listitem.getLabel().
  • Faster playback (since we don't need to do an EPG lookup anymore).
  • Seems to work fine in the skins I've tested (Arctic Zaphyr 2 & Estuary).
  • Much simpler code, no lookups needed by channel.

@mediaminister @dagwieers @MarcelRoozekrans

@michaelarnauts
Copy link
Contributor Author

Maybe I'll leave the old way in as a fallback. This allows to use IPTV Manager with EPG data from tvheadend (I agree, this is an advanced usecase).

@michaelarnauts michaelarnauts changed the title Use direct vod url in Kodi 18 Use direct URI to play programs from the EPG in Kodi 18 Jun 12, 2020
@MarcelRoozekrans
Copy link
Contributor

LGTM !

@michaelarnauts
Copy link
Contributor Author

The fallback to the templated URI can be useful when there is no direct stream available yet at the time when the EPG is fetched.

@michaelarnauts michaelarnauts merged commit 677d2d4 into add-ons:master Jun 12, 2020
@michaelarnauts michaelarnauts added the enhancement New feature or request label Jun 12, 2020
@dagwieers dagwieers added this to the v0.1.0 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants