Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts for figures #321

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Scripts for figures #321

merged 2 commits into from
Oct 21, 2022

Conversation

stefaniagl
Copy link
Contributor

Improved scripts for figures on PRA requirements

Thank you for contributing to ADDA. Please remove the Italic text (_..._) throughout this template after following the corresponding instructions

Description

Improved python scripts for the reproduction of updated figures from the article "Vector Bessel beams: General classification and scattering simulations" according to requirements of Physical Review A journal.

Related issues

Related to #209

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the contributing guidelines
  • The new code complies with the existing code style.
  • The code compiles correctly in all relevant regimes (at least, make seq)
  • The new code does not rely on any Fortran or C++ sources or is disabled by NO_FORTRAN or NO_CPP preprocessor macros, respectively.
  • The change neither adds or removes files; otherwise, these changes are reflected in README.md in corresponding folders.
  • No warnings appear during debug compilation (at least, make seq OPTIONS=DEBUG, but better devtools/build_debug) or they are discussed below
  • Tests pass locally with my changes (at least, sh comp2exec seq in tests/2exec, but better devtools/test_new [seq]). If any errors appear, they are discussed below.
  • I have added tests that prove my fix is effective or that my feature works. And these tests pass. This includes new command line in suite files in tests/2exec (and potentially new ignore patterns). In some cases, it is desirable to add new tests to tests/equiv.
  • I have added/extended necessary documentation (if appropriate). If suggesting changes to the manual, I have used "Track changes" in the doc file.
  • I have looked through all changes introduced by this pull request (line by line), using git diff or, better, some GUI tool, to ensure that no unexpected changes are introduced.

Further comments

In the future: the doi and other info of the article is still needed for the readme file.

Improved scripts for figures on PRA requirements
@myurkin myurkin self-assigned this Oct 21, 2022
@myurkin myurkin merged commit 251a26b into adda-team:master Oct 21, 2022
@myurkin
Copy link
Member

myurkin commented Oct 21, 2022

It's perfect now, thanks.

@stefaniagl stefaniagl deleted the temp branch November 18, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants