Skip to content

Commit

Permalink
src: move node_trace_writer/buffer.h to agent.cc
Browse files Browse the repository at this point in the history
The headers node_trace_writer.h and node_trace_buffer.h are not used in
agent.h but are more of an implementation detail of agent.cc.

This commit suggests moving the inclusion of these headers to agent.cc.

PR-URL: nodejs/node#15598
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
danbev authored and addaleax committed Sep 30, 2017
1 parent 7a26abd commit f0f1053
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/tracing/agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#include <sstream>
#include <string>
#include "tracing/node_trace_buffer.h"
#include "tracing/node_trace_writer.h"

#include "env-inl.h"

Expand Down
5 changes: 3 additions & 2 deletions src/tracing/agent.h
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
#ifndef SRC_TRACING_AGENT_H_
#define SRC_TRACING_AGENT_H_

#include "libplatform/v8-tracing.h"
#include "node_platform.h"
#include "tracing/node_trace_buffer.h"
#include "tracing/node_trace_writer.h"
#include "uv.h"
#include "v8.h"

namespace node {
namespace tracing {

using v8::platform::tracing::TracingController;

class Agent {
public:
Agent();
Expand Down

0 comments on commit f0f1053

Please sign in to comment.