Fix error when parsing .gyp file with a backslash #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding [Unify node.gyp code styling · Issue #41072 · nodejs/node](nodejs/node#41072), in `node.gyp`, multi-line character strings are combined by inserting `\` before a line break. That causes 'Unknown escape character' error in `gyp-parser`. This PR is a bug fix on the `gyp-parser` side.
addaleax
approved these changes
Dec 6, 2021
|
Thanks, merged and published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding Unify node.gyp code styling · Issue #41072 · nodejs/node, in
node.gyp, multi-line character strings are combined by inserting\before a line break.That causes 'Unknown escape character' error in
gyp-parser.This PR is a bug fix on the
gyp-parserside.