forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
zlib: warn before crash on invalid internals usage
Refs: nodejs#16649 Refs: nodejs#14161
- Loading branch information
Showing
2 changed files
with
30 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const cp = require('child_process'); | ||
|
||
if (process.argv[2] === 'child') { | ||
// This is the heart of the test. | ||
new (process.binding('zlib').Zlib)(0).init(1, 2, 3, 4, 5); | ||
} else { | ||
const child = cp.spawnSync(`${process.execPath}`, [`${__filename}`, 'child']); | ||
const stderr = child.stderr.toString(); | ||
|
||
assert.strictEqual(child.stdout.toString(), ''); | ||
assert.ok(child.stderr.includes( | ||
'WARNING: You are likely using a version of node-tar or npm that uses ' + | ||
'the internals of Node.js in an invalid way.\n' + | ||
'Please use either the version of npm that is bundled with Node.js, or ' + | ||
'a version of npm (> 5.5.1 or < 5.4.0) or node-tar (> 4.0.1) that is ' + | ||
'compatible with Node 9 and above.\n')); | ||
} |