Skip to content

Commit

Permalink
test: fix flaky test-inspector
Browse files Browse the repository at this point in the history
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

PR-URL: nodejs#9727
Fixes: nodejs#8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
  • Loading branch information
Trott authored and addaleax committed Dec 8, 2016
1 parent c5e806c commit 1296a68
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion test/inspector/inspector-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ TestSession.prototype.disconnect = function(childDone) {
this.expectClose_ = true;
this.harness_.childInstanceDone =
this.harness_.childInstanceDone || childDone;
this.socket_.end();
this.socket_.destroy();
console.log('[test]', 'Connection terminated');
callback();
});
Expand Down
1 change: 0 additions & 1 deletion test/inspector/inspector.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ prefix inspector
[true] # This section applies to all platforms

[$system==win32]
test-inspector : PASS,FLAKY

0 comments on commit 1296a68

Please sign in to comment.