Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Replacing term "hashtag" with "hash mark" to prevent spread of misinformation #357

Closed
wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2013

According to RFC 3986, the identifier following the number sign ("#") character is called a fragment identifier. Hashtag is a microblogging concept, and the terms should not be used interchangeably when referring to the structure of a URI.

Proper usage of hashtag, e.g. "Thanks for recently favoriting my hashtag-less tweet talking up this book."

Josh Habdas added 2 commits March 2, 2013 12:09
The hashtag is more of a concept for microblogging services like Twitter. The proper term for stuffs following the ("#") is "fragment identifier". Actual term omitted for brevity and ease of reading.
Replacing word "hashtag" with "hash mark"
@addyosmani
Copy link
Owner

Well spotted. This should definitely not be hashtag - could you let me know what you think of the comment on the change? I would be happy to merge otherwise (and thanks for the PR!)

Added the number sign symbol after the term "hash mark", preceding the existing examples that use it.
@ghost
Copy link
Author

ghost commented Mar 3, 2013

My pleasure. And thanks for getting back so quickly. Wasn't sure exactly what you were looking for, so I made a slight change to add additional clarification in a new commit. Hopefully that helps users understand what they're looking at in the examples already in place in the book.

@addyosmani
Copy link
Owner

@JHabdas I appreciate your changes here. It appears that this PR can't be merged at the moment but it would be fantastic if you could rebase. I think the clarification is perfect as is.

@addyosmani
Copy link
Owner

Thanks again! I've manually brought this in as I was working on the same files today.

@ghost
Copy link
Author

ghost commented Mar 10, 2013

Thanks for pulling in my changes, Addy. My feeble attempt to rebase last week ended up pulling in a bunch of unrelated commits, and so I had to do some history rewriting to keep this branch clean. Looking forward to continuing through the book.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant