This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Chapter 5: "Exercise 2 - Book Library" rewording and clarifications #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2013 20:40
Also changes LibraryView to use listenTo instead of on and to use Collection.each instead of _.each.
Conflicts: chapters/05-exercise-2.md
|
I greatly appreciate the time you took to go through the chapter and make the changes you did. These look great 🍰 |
addyosmani
added a commit
that referenced
this pull request
Mar 13, 2013
Chapter 5: "Exercise 2 - Book Library" rewording and clarifications
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I successfully worked through the example in Chapter 2 and did some minor rewording. I also changed the LibraryView to use listenTo() instead of on() and collection.each() instead of _.each().