This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Changed window.app.* to app.* to match the example code in Example 1 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed window.app.* to app.* to match the example code.
|
Those should probably be changed too for consistency. Would you like to update your PR to capture changes for them? :) |
|
Thanks @dwabyick! |
addyosmani
added a commit
that referenced
this pull request
May 25, 2013
Changed window.app.* to app.* to match the example code in Example 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed window.app.* to app.* to match the example code for the router example. There were a few other places earlier in the chapter that referred to window.app for the console log. Perhaps those should be changed too.