Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty href in link throws cryptic error #258

Closed
Saturate opened this issue Nov 28, 2017 · 4 comments
Closed

Empty href in link throws cryptic error #258

Saturate opened this issue Nov 28, 2017 · 4 comments
Assignees

Comments

@Saturate
Copy link

Saturate commented Nov 28, 2017

The following link tag in HTML
<link href="" media="all" rel="stylesheet">

Will give an error saying:
Unhandled rejection Error: EISDIR: illegal operation on a directory, read

This can be quite cryptic, as this was a series of bugs that I encountered, both with the href not getting rendered and then with the strange error from critical.

I makes sense as it tries to open a dir, and it can't in this instance, but I feel that it could be handled a little better.

Node: 8.5.0
Critical: 1.0.0

@Saturate Saturate changed the title Empty href gives cryptic error Empty href in link throws cryptic error Nov 28, 2017
@bezoerb bezoerb self-assigned this Dec 1, 2017
@bezoerb
Copy link
Collaborator

bezoerb commented Dec 1, 2017

Thanks for reporting @Saturate. We should definitely improve the error reporting

@chromadesign
Copy link

I am getting this rather cryptic error as well and can't find what the problem (it's not an empty href). I've tried different source URLs (local and remote) as well as different destination directories to no avail. Any idea how I can get to the bottom of this?

Fancy Log spits out the following error message after the task finishes:
Error: EISDIR: illegal operation on a directory, read errno: -4068, code: 'EISDIR', syscall: 'read' }

bezoerb added a commit that referenced this issue Apr 1, 2018
@bezoerb
Copy link
Collaborator

bezoerb commented Jan 8, 2019

Can you try the prerelease version of critical: npm i critical@next
We improved file handling & error reporting in this release.

@XhmikosR
Copy link
Collaborator

XhmikosR commented Aug 7, 2019

Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants