-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added penthouse timeout option #140
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
stable | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,9 @@ critical.generate({ | |
// Extract inlined styles from referenced stylesheets | ||
extract: true, | ||
|
||
// Complete Timeout for Operation | ||
timeout: 30000, | ||
|
||
// Prefix for asset directory | ||
pathPrefix: '/MySubfolderDocrot', | ||
|
||
|
@@ -219,6 +222,7 @@ critical.generate({ | |
| inlineImages | `boolean` | `false` | Inline images | ||
| assetPaths | `array` | `[]` | List of directories/urls where the inliner should start looking for assets | ||
| maxImageFileSize | `integer` | `10240`| Sets a max file size (in bytes) for base64 inlined images | ||
| timeout | `integer` | `30000`| Sets a maximum timeout for the operation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The column separators should be aligned with the others. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. friendly ping on this @leogdion There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. let me know if there is anything else. |
||
| pathPrefix | `string` | `/` | Path to prepend CSS assets with. You *must* make this path absolute if you are going to be using critical in multiple target files in disparate directory depths. (eg. targeting both `/index.html` and `/admin/index.html` would require this path to start with `/` or it wouldn't work.) | ||
| include | `array` | `[]` | Force include css rules. See [`penthouse#usage`](https://github.com/pocketjoso/penthouse#usage-1). | ||
| ignore | `array` | `[]` | Ignore css rules. See [`filter-css`](https://github.com/bezoerb/filter-css) for usage examples. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop the nvmrc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes