Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast numeric/decimal/money as a string #288

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

jgonera
Copy link
Contributor

@jgonera jgonera commented Jun 22, 2021

Numeric/decimal values are returned as strings by node-postgres
because they can exceed Number.MAX_SAFE_INTEGER.

@vercel
Copy link

vercel bot commented Jun 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/adels/pgtyped/DTEbWXzVkNgfvcVPs8WTcG1eWfMa
✅ Preview: https://pgtyped-git-fork-jgonera-patch-1-adels.vercel.app

@jgonera
Copy link
Contributor Author

jgonera commented Jun 22, 2021

After looking at it more closely, money should also be returned as a string.

Numeric/decimal/money values are returned as strings by node-postgres
because they can exceed `Number.MAX_SAFE_INTEGER`.
jgonera added a commit to jgonera/pgtyped that referenced this pull request Jun 22, 2021
Github Actions doesn't have any limits for open source projects so we
can make it run as often as possible.

It seems now the CI doesn't run on some PRs so perhaps relaxing the
triggers will fix it: adelsz#288

This reverts the change from 3e304e5.
@jgonera jgonera changed the title Cast numeric/decimal as a string Cast numeric/decimal/money as a string Jun 22, 2021
@adelsz adelsz merged commit bfd473b into adelsz:master Jul 6, 2021
@jgonera jgonera deleted the patch-1 branch January 24, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants