add Postgis Point type as number[] #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds an extra type to
cli/src/types.ts
, for the Postgis column typepoint
. The type is anumber[]
. Technically it could be typed more strictly as[number, number]
, but I believe that would involve more significant changes to pgTyped, and this is perfectly acceptable for our purposes.I have tested this by building the code and linking the
@pgtyped/cli
package to my application. It successfully removes thecolumn type not supported by mapping
errors that I was seeing before.Apologies if I have missed anything. Let me know if there are any further changes to make! Thank you.
This is a rudimentary solution to the issue discussed in #232, although only for the
point
type. I would be happy to add more Postgis types if there is demand for it.