Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load Smart Browser. #889

Merged

Conversation

EdwinBetanc0urt
Copy link
Collaborator

@EdwinBetanc0urt EdwinBetanc0urt commented May 29, 2021

Bug report / Feature

Steps to reproduce

  1. Open SB without process asociate (Request Browser).

Screenshot or Gif

Before this PR:
browser-loaded-error

After this PR:
https://user-images.githubusercontent.com/20288327/120058002-94e7d680-c015-11eb-8bb1-ce6c761bc262.mp4

Expected behavior

The smart browser is expected to open correctly.

Other relevant information

  • Your OS: Linux Mint 19.1 Cinnamon x64.
  • Browser: Mozilla Firefox 88.0.1.
  • Node.js version: 12.20.0.
  • adempiere-vue version: 4.3.1.

Additional context

Depends on adempiere/gRPC-API#4
Depends on adempiere/proxy-adempiere-api#25

closes #99

@EdwinBetanc0urt EdwinBetanc0urt self-assigned this May 29, 2021
@EdwinBetanc0urt EdwinBetanc0urt added 24 Basic Changes 02 Bug Something isn't working (UITL) UI Tools Windows, Process, Reports, Smart Browsers and other definitions from dictionary 06 Help wanted Extra attention is needed labels May 29, 2021
@oscarinak
Copy link
Collaborator

The PR verification was carried out in the following service "https://deploy-preview-889--stoic-lamport-68decf.netlify.app/" where the following observations were found:

  • When opening the SB it keeps throwing the same error
    -It was tried to open a second time and this one showed its view from ADempiere however it threw some error messages, which can be seen in the following Gif

Verificación_PullR_889

@oscarinak
Copy link
Collaborator

bad

@EdwinBetanc0urt
Copy link
Collaborator Author

@oscarinak For the tests to take effect, the following changes must first be approved and mounted on the demo server

@yamelsenih please check the above mentioned PRs.

@oscarinak
Copy link
Collaborator

The review was performed again and the error persists

image

@yamelsenih yamelsenih merged commit a30551d into adempiere:develop Jun 3, 2021
@EdwinBetanc0urt EdwinBetanc0urt deleted the bugfix/request-browser branch June 19, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Bug Something isn't working 06 Help wanted Extra attention is needed 24 Basic Changes (UITL) UI Tools Windows, Process, Reports, Smart Browsers and other definitions from dictionary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ADempiere SmartBrowser
3 participants