Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling fixes #909

Merged
merged 16 commits into from
Jun 9, 2021
Merged

Styling fixes #909

merged 16 commits into from
Jun 9, 2021

Conversation

sofia-ester-calderon
Copy link
Collaborator

Fixed styling of forms:

  • Field size is fixed to give consistent look
  • Mandatory fields are marked with red * instead of making whole label red
  • Textareas are not resizable - that function broke the styling
  • There is an info icon next to the labels to indicate that clicking on them will give more information
  • Info dropdown has more padding and margins
  • All is checked for mobile and desktop version

Before:
Screen Shot 2021-06-06 at 11 28 51 am

After:
Screen Shot 2021-06-06 at 11 28 30 am
Screen Shot 2021-06-06 at 11 29 47 am

@elsiosanchez
Copy link
Collaborator

Hello @sofia-ester-calderon. Please correct in desktop mode, 2 scrolls are displayed.

Peek 02-06-2021 17-24

image

@sofia-ester-calderon
Copy link
Collaborator Author

Hello @sofia-ester-calderon. Please correct in desktop mode, 2 scrolls are displayed.

@elsiosanchez I've reverted the changes I made here - it seems there are different styles in a Mac or a Windows machine. can you please check on your side if that fixes it? I only have a mac machine.

@elsiosanchez
Copy link
Collaborator

elsiosanchez commented Jun 8, 2021 •
edited
Loading

When I reverted the problem of multiple scroll was corrected.

@yamelsenih yamelsenih self-assigned this Jun 9, 2021
@yamelsenih yamelsenih added 24 Basic Changes 01 Enhancement New feature or request 27 Fast Resolution Very fast Resolution for a issue, can be completed along the day labels Jun 9, 2021
@yamelsenih yamelsenih merged commit 82dec26 into adempiere:develop Jun 9, 2021
yamelsenih added a commit to adempiere/adempiere-vue-docker that referenced this pull request Jun 11, 2021
@yamelsenih
## Related Commits
59d97ae 
- Styling fixes
[#909](adempiere/adempiere-vue#909)
- fix open window
[#908](adempiere/adempiere-vue#908)
- fix iSOcode pos
[#912](adempiere/adempiere-vue#912)
- support to quick guide
[#910](adempiere/adempiere-vue#910)
- Feature/add column pos
[#911](adempiere/adempiere-vue#911)
- Add option to change warehouse and price list
[#913](adempiere/adempiere-vue#913)
- Fix Check Price
[#914](adempiere/adempiere-vue#914)
- Inserted line breaks in side menu
[#915](adempiere/adempiere-vue#915)
@snyk-bot snyk-bot mentioned this pull request Mar 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamelsenih yamelsenih Awaiting requested review from yamelsenih

Assignees

@yamelsenih yamelsenih

Labels
01 Enhancement New feature or request 24 Basic Changes 27 Fast Resolution Very fast Resolution for a issue, can be completed along the day
Projects
None yet
Milestone
First Release (Testing Release)
Development

Successfully merging this pull request may close these issues.
3 participants
@sofia-ester-calderon @elsiosanchez @yamelsenih