Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate record-lock in different tab component. #919

Merged

Conversation

EdwinBetanc0urt
Copy link
Collaborator

@EdwinBetanc0urt EdwinBetanc0urt commented Jun 13, 2021

Bug report / Feature

A new component was created by separating the log locking logic from the parent tab component.

Steps to reproduce

  1. Open a window with records, in this case Product Group.
  2. Click on the padlock to lock/unlock the record

Screenshot or Gif

lock-record.mp4

Other relevant information

  • Your OS: Linux Mint 19.1 Cinnamon x64.
  • Browser: Mozilla Firefox 88.0.1.
  • Node.js version: 14.17.0.
  • NPM version: 7.17.0.
  • adempiere-vue version: 4.3.1.

Additional context:

fixes #146

@EdwinBetanc0urt
Copy link
Collaborator Author

@yamelsenih If the record id is not sent when locking or unlocking records, even if the record uuid is sent, the locking/unlocking will have no effect.

So the record uuid at this point may not be used for the services mentioned above.

@yamelsenih yamelsenih merged commit 74d8b7f into adempiere:develop Jun 18, 2021
@EdwinBetanc0urt EdwinBetanc0urt deleted the feature/separate-lock-record branch July 24, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to private access
2 participants