Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tag '3.9.4' into develop #4068

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Merge tag '3.9.4' into develop #4068

merged 1 commit into from
Feb 9, 2023

Conversation

yamelsenih
Copy link
Member

ADempiere Foundation Release 3.9.4

ADempiere Foundation Release 3.9.4
Copy link
Collaborator

@marcalwestf marcalwestf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked both branches in Eclipse to be sure.
imagen

@marcalwestf marcalwestf merged commit 5758dda into master Feb 9, 2023
@marcalwestf
Copy link
Collaborator

This is how it looks now:
imagen

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


This is how it looks now:
imagen

@e-Evolution
Copy link
Contributor

According to gitflow best practice, which is the development procedure we follow in the project, the master branch only commits to official releases, so this merge violates the regular procedure.

this is the main reason to reverse it.

Please read the current procedure
https://adempiere.gitbook.io/docs/developer-guide/software-development-procedure

@marcalwestf and @yamelsenih , I ask that before doing something of which you are not sure or poorly documented, ask before taking any action so that this does not become a real mess

Bibliography:

https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow

https://www.atlassian.com/en/git/tutorials/comparing-workflows/gitflow-workflow#:~:text=%C2%BFQu%C3%A9%20en%20Gitflow%3F,vez%20y%20who% 20lo%20populariz%C3%B3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants