Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve OPTIONS http request. #27

Merged

Conversation

EdwinBetanc0urt
Copy link
Contributor

@EdwinBetanc0urt EdwinBetanc0urt commented May 23, 2024

In some browsers like Mozilla Firefox when making a request with the http method GET before executing a request with the http method OPTIONS for performance as a ping to verify if the server responds.

Currently we are listening to the routes for GET methods accompanied by the OPTIONS (for compatibility with Mozilla Firefox), however in the OPTIONS it executes the search function to the OpenSearch that is already done in the get, so it is making undue use of resources and traffic and can return a code 204 No Content which is the one expected by the OPTIONS method without having to return the body of the response.

imagen

imagen

@yamelsenih yamelsenih merged commit cae98ed into adempiere:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants