Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terraform consistent variables for machine deployment replicas #1

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

adeniyistephen
Copy link
Owner

@adeniyistephen adeniyistephen commented Jun 23, 2022

What type of PR is this?
Fixing terraform variables for consistency among cloud providers

What this PR does / why we need it:
To enable consistent variables among cloud providers for the machine deployment replicas.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/kubermatic/ps-team-flotilla/issues/99 ticket

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@adeniyistephen adeniyistephen merged commit e80d7f7 into master Jun 23, 2022
@adeniyistephen adeniyistephen deleted the terraform-consistent-var branch June 23, 2022 13:17
@adeniyistephen adeniyistephen restored the terraform-consistent-var branch June 23, 2022 13:18
@stroebitzer
Copy link

Looks good to me. Please check with Artiom the following things:

  • On Hetzner this would be a breaking change. Ask Artiom if that is OK, at least we have to document it in the release notes that it is a breaking change
  • Please ensure that the docs are also updated. So the KubeOne docs and the examples in the KubeOne repo

@adeniyistephen
Copy link
Owner Author

You mean so the kubeone docs and example both rhyme with same updates?

@stroebitzer
Copy link

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants