Add review changes

adevinta · Dec 16, 2024 · b231b1c · b231b1c
1 parent 06a6c09
commit b231b1c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 19 deletions.
diff --git a/catalog/src/main/kotlin/com/adevinta/spark/catalog/configurator/Navigation.kt b/catalog/src/main/kotlin/com/adevinta/spark/catalog/configurator/Navigation.kt
@@ -22,7 +22,6 @@
 package com.adevinta.spark.catalog.configurator
 
 import androidx.compose.foundation.layout.PaddingValues
-import androidx.navigation.NavController
 import androidx.navigation.NavGraphBuilder
 import androidx.navigation.NavHostController
 import androidx.navigation.compose.composable
@@ -43,7 +42,9 @@ internal fun NavGraphBuilder.configuratorsDestination(
         ComponentsListScreen(
             components = components,
             contentPadding = contentPadding,
-            onConfiguratorClick = navController::navigateToConfiguratorShowcase,
+            onConfiguratorClick = { id ->
+                navController.navigate(route = ConfiguratorShowcase(componentId = id))
+            },
         )
     }
 
@@ -57,7 +58,3 @@ internal fun NavGraphBuilder.configuratorsDestination(
         )
     }
 }
-
-private fun NavController.navigateToConfiguratorShowcase(id: Int) {
-    navigate(route = ConfiguratorShowcase(componentId = id))
-}
diff --git a/catalog/src/main/kotlin/com/adevinta/spark/catalog/examples/Navigation.kt b/catalog/src/main/kotlin/com/adevinta/spark/catalog/examples/Navigation.kt
@@ -22,7 +22,6 @@
 package com.adevinta.spark.catalog.examples
 
 import androidx.compose.foundation.layout.PaddingValues
-import androidx.navigation.NavController
 import androidx.navigation.NavGraphBuilder
 import androidx.navigation.NavHostController
 import androidx.navigation.compose.composable
@@ -51,7 +50,7 @@ internal fun NavGraphBuilder.examplesDestination(
             components = components,
             contentPadding = contentPadding,
             onExampleSectionClick = {
-                navController.navigateToExampleSection(id = it)
+                navController.navigate(route = ExampleSection(componentId = id))
             },
         )
     }
@@ -65,7 +64,7 @@ internal fun NavGraphBuilder.examplesDestination(
             contentPadding = contentPadding,
             onExampleClick = { example ->
                 val exampleIndex = component.examples.indexOf(example)
-                navController.navigateToExampleShowcase(id = componentId, index = exampleIndex)
+                navController.navigate(route = ExampleShowcase(componentId = id, exampleIndex = exampleIndex))
             },
         )
     }
@@ -78,11 +77,3 @@ internal fun NavGraphBuilder.examplesDestination(
         Example(example = example)
     }
 }
-
-private fun NavController.navigateToExampleSection(id: Int) {
-    navigate(route = ExampleSection(componentId = id))
-}
-
-private fun NavController.navigateToExampleShowcase(id: Int, index: Int) {
-    navigate(route = ExampleShowcase(componentId = id, exampleIndex = index))
-}
diff --git a/catalog/src/main/kotlin/com/adevinta/spark/catalog/icons/Navigation.kt b/catalog/src/main/kotlin/com/adevinta/spark/catalog/icons/Navigation.kt
@@ -22,7 +22,6 @@
 package com.adevinta.spark.catalog.icons
 
 import androidx.compose.foundation.layout.PaddingValues
-import androidx.navigation.NavController
 import androidx.navigation.NavGraphBuilder
 import androidx.navigation.NavHostController
 import androidx.navigation.compose.composable
@@ -42,7 +41,7 @@ internal fun NavGraphBuilder.iconsDemoDestination(
             contentPadding = contentPadding,
             onIconClick = { id, name, isAnimated ->
                 navController.navigate(
-                    route = IconShowcase(iconId = id, iconName = name, isIconAnimated = isAnimated)
+                    route = IconShowcase(iconId = id, iconName = name, isIconAnimated = isAnimated),
                 )
             },
         )