Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update base colors to new specs #1404

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat: Update base colors to new specs #1404

merged 3 commits into from
Dec 16, 2024

Conversation

soulcramer
Copy link
Contributor

@soulcramer soulcramer commented Dec 16, 2024

📋 Changes

Changed the palette values and the color tokens referenced colors.
Removed the legacy theme provider values as the defualt theme is the lbc one.

🤔 Context

Theme colors have been adjusted to be more a11y
Close SPA-444

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • If it includes design changes, please ask for a review spark-design GitHub team.

📸 Screenshots

delta-com adevinta spark tokens_ColorsScreenshot_themesColors__light
image

Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew cleanRecordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

Copy link
Contributor

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.11.1 Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.11.1 Build Scan not published

Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew cleanRecordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

Copy link
Contributor

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.11.1 Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.11.1 Build Scan not published

@soulcramer soulcramer merged commit 06f5ee4 into main Dec 16, 2024
6 checks passed
@soulcramer soulcramer deleted the New-theme-colors branch December 16, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants