feat: update esling config following PR feedbacks

Update esling config following PR feedbacks
adevinta · Jun 1, 2023 · 609e6e4 · 609e6e4
1 parent dff1331
commit 609e6e4
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 46 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -7,6 +7,12 @@ module.exports = {
         'max-nested-callbacks': [1, 4],
       },
     },
+    {
+      files: ['**/*.tsx'],
+      rules: {
+        'max-lines-per-function': [1, { max: 150, skipBlankLines: true, skipComments: true }],
+      },
+    },
   ],
   settings: {
     react: {

diff --git a/packages/components/tabs/src/TabsList.tsx b/packages/components/tabs/src/TabsList.tsx
@@ -133,7 +133,19 @@ export const TabsList = forwardRef<HTMLDivElement, TabsListProps>(
     return (
       <div className={wrapperStyles({ className })} ref={wrapperRef}>
         {arrows.prev !== 'hidden' && (
-          <Components.Prev handleClick={handlePrevClick} disabled={arrows.prev === 'disabled'} />
+          <Button
+            shape="square"
+            intent="surface"
+            size="sm"
+            className={navigationArrowStyles()}
+            onClick={handlePrevClick}
+            disabled={arrows.prev === 'disabled'}
+            aria-label="Scroll left"
+          >
+            <Icon>
+              <ArrowVerticalLeft />
+            </Icon>
+          </Button>
         )}
 
         <RadixTabs.List
@@ -147,55 +159,23 @@ export const TabsList = forwardRef<HTMLDivElement, TabsListProps>(
         </RadixTabs.List>
 
         {arrows.next !== 'hidden' && (
-          <Components.Next handleClick={handleNextClick} disabled={arrows.prev === 'disabled'} />
+          <Button
+            shape="square"
+            intent="surface"
+            size="sm"
+            className={navigationArrowStyles()}
+            onClick={handleNextClick}
+            disabled={arrows.next === 'disabled'}
+            aria-label="Scroll right"
+          >
+            <Icon>
+              <ArrowVerticalRight />
+            </Icon>
+          </Button>
         )}
       </div>
     )
   }
 )
 
-interface ComponentsProps {
-  NavigationBtn: {
-    handleClick: () => void
-    disabled?: boolean
-  }
-}
-
-const Components = {
-  Prev: ({ handleClick, disabled }: ComponentsProps['NavigationBtn']) => {
-    return (
-      <Button
-        shape="square"
-        intent="surface"
-        size="sm"
-        className={navigationArrowStyles()}
-        onClick={handleClick}
-        disabled={disabled}
-        aria-label="Scroll left"
-      >
-        <Icon>
-          <ArrowVerticalLeft />
-        </Icon>
-      </Button>
-    )
-  },
-  Next: ({ handleClick, disabled }: ComponentsProps['NavigationBtn']) => {
-    return (
-      <Button
-        shape="square"
-        intent="surface"
-        size="sm"
-        className={navigationArrowStyles()}
-        onClick={handleClick}
-        disabled={disabled}
-        aria-label="Scroll right"
-      >
-        <Icon>
-          <ArrowVerticalRight />
-        </Icon>
-      </Button>
-    )
-  },
-}
-
 TabsList.displayName = 'Tabs.List'