Skip to content

Commit

Permalink
feat(radio-group): new colours strategy
Browse files Browse the repository at this point in the history
new colours strategy

BREAKING CHANGE: new colours strategy
andresin87 authored and acd02 committed Aug 2, 2023

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
1 parent be0d7b8 commit db4c2cf
Showing 5 changed files with 27 additions and 21 deletions.
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/components/radio-group/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@spark-ui/radio-group",
"version": "1.5.2",
"version": "1.5.2-colours.0",
"description": "Component used when only one choice may be selected in a series of options",
"publishConfig": {
"access": "public"
@@ -16,7 +16,7 @@
"@radix-ui/react-label": "2.0.1",
"@radix-ui/react-radio-group": "1.1.2",
"@spark-ui/form-field": "^1.2.1",
"@spark-ui/internal-utils": "^1.6.1",
"@spark-ui/internal-utils": "colours",
"class-variance-authority": "0.5.2"
},
"peerDependencies": {
6 changes: 4 additions & 2 deletions packages/components/radio-group/src/RadioGroup.stories.tsx
Original file line number Diff line number Diff line change
@@ -66,8 +66,10 @@ export const Controlled: StoryFn = () => {
}

const intents: RadioGroupProps['intent'][] = [
'primary',
'secondary',
'main',
'support',
'accent',
'basic',
'info',
'neutral',
'success',
10 changes: 6 additions & 4 deletions packages/components/radio-group/src/RadioIndicator.styles.ts
Original file line number Diff line number Diff line change
@@ -19,10 +19,12 @@ export const radioIndicatorStyles = cva(
variants: {
intent: makeVariants<
'intent',
['primary', 'secondary', 'success', 'alert', 'error', 'info', 'neutral']
['main', 'support', 'accent', 'basic', 'success', 'alert', 'error', 'info', 'neutral']
>({
primary: ['after:bg-primary'],
secondary: ['after:bg-secondary'],
main: ['after:bg-main'],
support: ['after:bg-support'],
accent: ['after:bg-accent'],
basic: ['after:bg-basic'],
neutral: ['after:bg-neutral'],
success: ['after:bg-success'],
alert: ['after:bg-alert'],
@@ -31,7 +33,7 @@ export const radioIndicatorStyles = cva(
}),
},
defaultVariants: {
intent: 'primary',
intent: 'basic',
},
}
)
18 changes: 10 additions & 8 deletions packages/components/radio-group/src/RadioInput.styles.ts
Original file line number Diff line number Diff line change
@@ -17,18 +17,20 @@ export const radioInputVariants = cva(
variants: {
intent: makeVariants<
'intent',
['primary', 'secondary', 'success', 'alert', 'error', 'info', 'neutral']
['main', 'support', 'accent', 'basic', 'success', 'alert', 'error', 'info', 'neutral']
>({
primary: [
main: ['border-outline', 'spark-state-checked:border-main', 'hover:ring-main-container'],
support: [
'border-outline',
'spark-state-checked:border-primary',
'hover:ring-primary-container',
'spark-state-checked:border-support',
'hover:ring-support-container',
],
secondary: [
accent: [
'border-outline',
'spark-state-checked:border-secondary',
'hover:ring-secondary-container',
'spark-state-checked:border-accent',
'hover:ring-accent-container',
],
basic: ['border-outline', 'spark-state-checked:border-basic', 'hover:ring-basic-container'],
neutral: [
'border-outline',
'spark-state-checked:border-neutral',
@@ -41,7 +43,7 @@ export const radioInputVariants = cva(
}),
},
defaultVariants: {
intent: 'primary',
intent: 'basic',
},
}
)

0 comments on commit db4c2cf

Please sign in to comment.