Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Loading state - Update the specs to allow for the default option of having only the spinner on the left #1957

Closed
Bibisirius opened this issue Mar 12, 2024 · 2 comments · Fixed by #2020
Assignees
Labels
Component: button Related to button component

Comments

@Bibisirius
Copy link

Bibisirius commented Mar 12, 2024

We've decided to offer the option to display the spinner only on the left. This will maintain consistency with Android constraints.

Image

@Bibisirius Bibisirius added this to the 2024 Q1 - Sprint 5 milestone Mar 12, 2024
@Bibisirius Bibisirius added the Component: button Related to button component label Mar 12, 2024
@andresin87 andresin87 self-assigned this Mar 19, 2024
@Powerplex
Copy link
Contributor

We met between web devs and decided that there is no reason to hardcode this limitation in the code as this will add unnecessary complexity. It can remain a Spark/Polaris guidelines and no change is necessary.

@Bibisirius
Copy link
Author

Okay, noted @Powerplex !
In order to maintain consistency with the apps, we'll need to synchronize with the specs only for this point. No need to code it, just remove the loading right in the specs.

andresin87 added a commit that referenced this issue Apr 3, 2024
…railing icon of the loadingText

removes the spinner placement of the button

BREAKING CHANGE: removes the spinner placement prop of the button not allowing to set it as a
leading icon when loading state is abled
#1957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: button Related to button component
Projects
None yet
4 participants