fix(select): remove code causing excessive calls to the onValueChange prop

[acd02]

TASK: #2062

Description, Motivation and Context

While using the Select component in controlled mode, two issues have been observed:

1. The onValueChange prop is executed on initial render, even though the value has not been changed.
2. Each time the value changes, the onValueChange prop is executed twice.

Repro ➡ https://stackblitz.com/edit/stackblitz-starters-ulfsq2?file=pagesContent%2Findex.tsx

The problem seems to originate from packages/components/select/src/SelectContext.tsx, specifically this piece of code:

useEffect(() => {
  if (valueProp) setValue(valueProp)
}, [valueProp, setValue])

The weird thing is, when we comment out what's inside the useEffect, all the tests still pass. And even when we interact with the component in the browser (in both controlled and uncontrolled modes), it doesn't seem to break anything

Types of changes

• 🛠️ Tool
• 🪲 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🧾 Documentation
• 📷 Demo
• 🧪 Test
• 🧠 Refactor
• 💄 Styles

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (8c60fc3) to head (0125440).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files         748      748              
  Lines        5851     5849       -2     
  Branches     2060     2059       -1     
==========================================
- Hits         5716     5714       -2     
  Misses        133      133              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.