feat: enhance our theme building process by implementing support for various base font sizes #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acd02
requested review from
andresin87,
arnau-rius,
andresz1,
turolopezsanabria,
thomas-leguellec,
victorsolajurnet,
Powerplex and
solygambas
as code owners
Powerplex
approved these changes
Mar 9, 2023
acd02
deleted the
385-enhance-our-theme-building-process-by-implementing-support-for-various-base-font-sizes
branch
Powerplex
reviewed
Mar 9, 2023
| @@ -219,6 +219,7 @@ export interface Theme { | |||
|
|
|||
| export interface ThemeConfig { | |||
| tailwindThemeConfigPath: string | |||
| htmlFontSize?: number | |||
There was a problem hiding this comment.
Maybe add a JSDoc comment for each keys in that interface :D
That way it will shows in IDE's for developers.
The base value for `1rem` is `16px`.
Use this option if your codebase uses a different value (ex: `htmlFontSize: 10`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implement support for various base font sizes
TASK: #385
Types of changes