Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "icarQuarterId" in the TreamentEventressources? #221

Closed
dirbSEGES opened this issue Jun 17, 2021 · 4 comments · Fixed by #230
Closed

Add "icarQuarterId" in the TreamentEventressources? #221

dirbSEGES opened this issue Jun 17, 2021 · 4 comments · Fixed by #230
Labels
this-release Scheduled to be implemented for this release in development

Comments

@dirbSEGES
Copy link

Hi

We miss the possibility to define the QuarterId for the treatment.

@erwinspeybroeck
Copy link
Collaborator

It is now defined as

_
site | string Body site where the treatment was administered

_

This could probably be more elaborated.
In our API we use

_
positions | [position
string
The position to be treated.
Enum:[ LEGS_FRONT_LEFT, LEGS_FRONT_RIGHT, LEGS_REAR_LEFT, LEGS_REAR_RIGHT, UDDER_FRONT_LEFT, UDDER_FRONT_RIGHT, UDDER_REAR_LEFT, UDDER_REAR_RIGHT, OVARIES_LEFT, OVARIES_RIGHT, OVARIES_UNKNOWN ]

_

@cookeac
Copy link
Collaborator

cookeac commented Jul 1, 2021

I think we left site as a string because different systems seemed to use a wide range of position coding. I do like this list, but I'm not sure how generally used it would be.

@cookeac
Copy link
Collaborator

cookeac commented Jul 8, 2021

At the most recent meeting we decided that we would investigate whether there was any consistency in the use of treatment location (treatment method can be specified using the procedure attribute). If there is international consistency, it would be useful to define an enumeration for the site attribute, otherwise it may be better used as a string in the standard and extended with a valid list only for local/national use.

@cookeac
Copy link
Collaborator

cookeac commented Jul 15, 2021

Agreed we should add a new field, such as "treatmentSites" - an array of enumerated strings.
"site" will remain for people who just record a text description.

@cookeac cookeac added the this-release Scheduled to be implemented for this release in development label Jul 15, 2021
cookeac added a commit to cookeac/ICAR that referenced this issue Jul 29, 2021
Changed the case and slightly extended the positions enumeration, moving it to ..\enums\icarPositionOnAnimal.json.
This and the previous pull request it is based on resolves adewg#221.
@cookeac cookeac linked a pull request Jul 29, 2021 that will close this issue
@cookeac cookeac closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
this-release Scheduled to be implemented for this release in development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants