Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sourceId to icarMetaDataType #197

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Add sourceId to icarMetaDataType #197

merged 3 commits into from
Mar 1, 2021

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Feb 25, 2021

resolves #153

@cookeac cookeac added the this-release Scheduled to be implemented for this release in development label Feb 25, 2021
erwinspeybroeck
erwinspeybroeck reviewed Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andrew, I agree. This is how we are implementing it at the moment with Lely.

@cookeac cookeac merged commit 27954d0 into adewg:Develop Mar 1, 2021
@cookeac cookeac mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinspeybroeck erwinspeybroeck erwinspeybroeck left review comments

@ahokkonen ahokkonen Awaiting requested review from ahokkonen

Assignees
No one assigned
Labels
this-release Scheduled to be implemented for this release in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cookeac @erwinspeybroeck