Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostalAddress to consignment origin and dest #322

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Sep 12, 2022

Define PostalAddress from schema.org, and add it to icarConsignment's originAddress and destinationAddress. This uses "anyOf" to support backward compatibility for the simple string type. Resolves #317

Define PostalAddress from schema.org, and add it to icarConsignment's originAddress and destinationAddress.
This uses "anyOf" to support backward compatibility for the simple string type.
Resolves adewg#317
@cookeac cookeac linked an issue Sep 13, 2022 that may be closed by this pull request
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - no remarks

@cookeac cookeac merged commit 9662bca into adewg:Develop Sep 16, 2022
@cookeac cookeac deleted the Consignment-Address branch March 9, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding PostalAddress to icarConsignmentType
2 participants