Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout now configurable #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Timeout now configurable #20

wants to merge 3 commits into from

Conversation

mhjmaas
Copy link

@mhjmaas mhjmaas commented Nov 9, 2015

Made it possible to configure the default timeout by adding an
“df-selenium-tools.properties” file next to the jar file. This file
must contain the “default.wait.timeout = ” property.

Please note this property is only read when loading the jar file to
optimise performance. When there is no file present it will revert to
the default of 30 seconds

Made it possible to configure the default timeout by adding an
“df-selenium-tools.properties” file next to the jar file. This file
must contain the “default.wait.timeout = <msecs>” property.

Please note this property is only read when loading the jar file to
optimise performance. When there is no file present it will revert to
the default of 30 seconds
@wvanderdeijl
Copy link
Member

Wouldn't a system property be much simpler? That's simpler to read and doesn't require all the file operations. Even if we would go for a properties file, I would prefer a simple load from classpath.
But my first option would be a simple system property.

@mhjmaas
Copy link
Author

mhjmaas commented Nov 9, 2015

Hi Wilfred,

I'll have a look at the system property approach. Hold off on the pull
request for a moment then.

Gr. Marcel

2015-11-09 15:24 GMT+01:00 Wilfred van der Deijl notifications@github.com:

Wouldn't a system property be much simpler? That's simpler to read and
doesn't require all the file operations. Even if we would go for a
properties file, I would prefer a simple load from classpath.
But my first option would be a simple system property.


Reply to this email directly or view it on GitHub
#20 (comment)
.

The default.wait.timeout can now be set as a system property and if set
will use this value. Otherwise it will revert to the original. Also
added the AdfPanelCollection component
@mhjmaas
Copy link
Author

mhjmaas commented Jan 4, 2016

Hi Wilfred,

I've updated the code to use a system property. Also I have added another component.

Greetings,

Marcel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants