Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update ember to 3.16.5 #414

Merged
merged 1 commit into from
Mar 24, 2020
Merged

fix(deps): update ember to 3.16.5 #414

merged 1 commit into from
Mar 24, 2020

Conversation

fkm
Copy link
Contributor

@fkm fkm commented Mar 23, 2020

@fkm fkm requested review from czosel, anehx and Yelinz March 23, 2020 16:41
@anehx
Copy link
Member

anehx commented Mar 24, 2020

Did you do this with ember-cli-update?

@czosel
Copy link
Contributor

czosel commented Mar 24, 2020

I wanted to ask exactly the same question 😅

@fkm
Copy link
Contributor Author

fkm commented Mar 24, 2020

I changed it manually. Running the cli now.

@fkm
Copy link
Contributor Author

fkm commented Mar 24, 2020

Done

czosel
czosel approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fkm fkm merged commit 02b212e into adfinis:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czosel czosel czosel approved these changes

@anehx anehx Awaiting requested review from anehx

@Yelinz Yelinz Awaiting requested review from Yelinz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fkm @anehx @czosel @fkm-adfinis