Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(barman): Add additional conf options #615

Merged
merged 2 commits into from
Mar 31, 2022
Merged

feature(barman): Add additional conf options #615

merged 2 commits into from
Mar 31, 2022

Conversation

ggggut
Copy link
Contributor

@ggggut ggggut commented Mar 31, 2022

Description

Add additional Values for configuring container volumeMounts and deployment volumes.
This will be useful if you want to have pre/post scripts in Barman (configmaps).
It templates the whole thing with toYaml.

Furthermore I added additionalConfiguration to make all parameters from https://docs.pgbarman.org/release/2.19/barman.5.html available for configuring your barman instance.
This will take a string + multiline string. So configuration would look like:

# this
  backups:
      additionalConfiguration: |
        pre_backup_script = "/path/to/your/script.py"
        minimum_redundancy = 2

# or this
  backups:
      additionalConfiguration: "minimum_redundancy = 2"

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@ggggut ggggut requested review from a team and michaelimfeld as code owners March 31, 2022 14:51
@ggggut ggggut requested review from eyenx and vmaillot and removed request for a team March 31, 2022 14:51
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2022
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit: please use nindent instead of indent for consistency

other than that, this LGTM from my pov

charts/barman/templates/configmap-barman-backups.yaml Outdated Show resolved Hide resolved
@hairmare hairmare merged commit eaa9bed into adfinis:master Mar 31, 2022
@hairmare
Copy link
Contributor

Thanks very much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants